Add PHPStan with strict rules

composer.json

@@ -35,6 +35,8 @@
         "php": "^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^1.10",
+        "phpstan/phpstan-strict-rules": "^1.5",
         "friendsofphp/php-cs-fixer": "^3.0"
     },
     "autoload": {

phpstan.dist.neon

@@ -0,0 +1,14 @@
+#
+# Configuration for PHPStan.
+# @see https://phpstan.org/config-reference
+#
+
+includes:
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
+
+parameters:
+    level: 2
+    strictRules:
+        noVariableVariables: false
+    paths:
+        - src

src/DataStructures/StrictList.php

@@ -31,11 +31,6 @@ use OCC\Basics\Traits\Getter;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \ArrayAccess
- * @implements \Countable
- * @implements \Iterator
- * @implements \Serializable
  */
 class StrictList extends SplDoublyLinkedList
 {

src/DataStructures/StrictQueue.php

@@ -29,11 +29,6 @@ use RuntimeException;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \ArrayAccess
- * @implements \Countable
- * @implements \Iterator
- * @implements \Serializable
  */
 class StrictQueue extends StrictList
 {

src/DataStructures/StrictStack.php

@@ -29,11 +29,6 @@ use RuntimeException;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \ArrayAccess
- * @implements \Countable
- * @implements \Iterator
- * @implements \Serializable
  */
 class StrictStack extends StrictList
 {

src/Functions/throwErrorException.php

@@ -43,7 +43,7 @@ use ErrorException;
  */
 function throwErrorException(int $severity = E_USER_ERROR, string $message = '', ?string $file = null, ?int $line = null): bool
 {
-    if (error_reporting() & $severity) {
+    if ((error_reporting() & $severity) > 0) {
         throw new ErrorException($message, 0, $severity, $file, $line);
     }
     return false;

src/InterfaceTraits/ArrayAccess.php

@@ -27,8 +27,6 @@ namespace OCC\Basics\InterfaceTraits;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \ArrayAccess
  */
 trait ArrayAccess /* implements \ArrayAccess */
 {

src/InterfaceTraits/Countable.php

@@ -27,8 +27,6 @@ namespace OCC\Basics\InterfaceTraits;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \Countable
  */
 trait Countable /* implements \Countable */
 {

src/InterfaceTraits/Iterator.php

@@ -27,8 +27,6 @@ namespace OCC\Basics\InterfaceTraits;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \Iterator
  */
 trait Iterator /* implements \Iterator */
 {

src/InterfaceTraits/IteratorAggregate.php

@@ -29,8 +29,6 @@ use ArrayIterator;
  *
  * @author Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
  * @package opencultureconsulting/basics
- *
- * @implements \IteratorAggregate
  */
 trait IteratorAggregate /* implements \IteratorAggregate */
 {