From ce210cd99bf43094d46568ad0b6dfbf8de0167a2 Mon Sep 17 00:00:00 2001
From: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
Date: Thu, 11 Jul 2024 15:20:35 +0200
Subject: [PATCH] Use array_key_exists instead of in_array

---
 src/Console.php                      | 2 +-
 src/Console/UpdateFormatsCommand.php | 4 ++--
 src/Middleware/ErrorHandler.php      | 2 +-
 src/Middleware/ListIdentifiers.php   | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/Console.php b/src/Console.php
index 3a5d0ba..49f4099 100644
--- a/src/Console.php
+++ b/src/Console.php
@@ -93,7 +93,7 @@ abstract class Console extends Command
         $arguments = $input->getArguments();
 
         $formats = Database::getInstance()->getMetadataFormats()->getQueryResult();
-        if (!in_array($arguments['format'], array_keys($formats), true)) {
+        if (!array_key_exists($arguments['format'], $formats)) {
             $output->writeln([
                 '',
                 sprintf(
diff --git a/src/Console/UpdateFormatsCommand.php b/src/Console/UpdateFormatsCommand.php
index 6e5d456..fd92976 100644
--- a/src/Console/UpdateFormatsCommand.php
+++ b/src/Console/UpdateFormatsCommand.php
@@ -61,7 +61,7 @@ class UpdateFormatsCommand extends Console
         $deleted = 0;
         $failure = false;
         foreach ($formats as $prefix => $format) {
-            if (in_array($prefix, array_keys($inDatabase), true)) {
+            if (array_key_exists($prefix, $inDatabase)) {
                 if (
                     $format['namespace'] === $inDatabase[$prefix]->getNamespace()
                     and $format['schema'] === $inDatabase[$prefix]->getSchema()
@@ -91,7 +91,7 @@ class UpdateFormatsCommand extends Console
             }
         }
         foreach (array_keys($inDatabase) as $prefix) {
-            if (!in_array($prefix, array_keys($formats), true)) {
+            if (!array_key_exists($prefix, $formats)) {
                 Database::getInstance()->deleteMetadataFormat($inDatabase[$prefix]);
                 ++$deleted;
                 $output->writeln([
diff --git a/src/Middleware/ErrorHandler.php b/src/Middleware/ErrorHandler.php
index 5f484e8..ba88ad6 100644
--- a/src/Middleware/ErrorHandler.php
+++ b/src/Middleware/ErrorHandler.php
@@ -113,7 +113,7 @@ class ErrorHandler extends AbstractMiddleware
      */
     public function withError(string $errorCode): ErrorHandler
     {
-        if (in_array($errorCode, array_keys(self::OAI_ERRORS), true)) {
+        if (array_key_exists($errorCode, self::OAI_ERRORS)) {
             $this->errors[] = $errorCode;
         } else {
             throw new DomainException(
diff --git a/src/Middleware/ListIdentifiers.php b/src/Middleware/ListIdentifiers.php
index ae45297..4bd6d4d 100644
--- a/src/Middleware/ListIdentifiers.php
+++ b/src/Middleware/ListIdentifiers.php
@@ -72,7 +72,7 @@ class ListIdentifiers extends Middleware
             }
         }
         $prefixes = Database::getInstance()->getMetadataFormats()->getQueryResult();
-        if (!in_array($metadataPrefix, array_keys($prefixes), true)) {
+        if (!array_key_exists($metadataPrefix, $prefixes)) {
             ErrorHandler::getInstance()->withError('cannotDisseminateFormat');
             return;
         }
@@ -84,7 +84,7 @@ class ListIdentifiers extends Middleware
         }
         if (isset($set)) {
             $sets = Database::getInstance()->getSets()->getQueryResult();
-            if (!in_array($set, array_keys($sets), true)) {
+            if (!array_key_exists($set, $sets)) {
                 ErrorHandler::getInstance()->withError('noSetHierarchy');
                 return;
             }