opencultureconsulting/oai-pmh2
2
0
Fork 0
mirror of https://github.com/opencultureconsulting/oai-pmh2.git synced 2025-03-30 00:00:30 +01:00
Code Issues

Fix PHPStan issue with differing PHP versions

Browse Source
This commit is contained in:
Sebastian Meyer 2025-03-23 09:52:12 +01:00
parent 0228d2fd5a
commit 1ad0bb6d6e
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
phpstan.dist.neon
View File

@ -10,6 +10,7 @@ includes:
parameters: parameters:
level: 9 level: 9
phpVersion: 80100 # PHP 8.1
treatPhpDocTypesAsCertain: false treatPhpDocTypesAsCertain: false
ignoreErrors: ignoreErrors:
- identifier: ternary.shortNotAllowed - identifier: ternary.shortNotAllowed

5
src/Console/CsvImportCommand.php
View File

@ -211,6 +211,7 @@ final class CsvImportCommand extends Console
'dateColumn' => $input->getOption('dateColumn'), 'dateColumn' => $input->getOption('dateColumn'),
'setColumn' => $input->getOption('setColumn') 'setColumn' => $input->getOption('setColumn')
]; ];
$filename = stream_get_meta_data($file)['uri'] ?? '';
$headers = fgetcsv($file, null, ",", "\"", "\\"); $headers = fgetcsv($file, null, ",", "\"", "\\");
if (!is_array($headers) || is_null($headers[0])) { if (!is_array($headers) || is_null($headers[0])) {
@ -218,7 +219,7 @@ final class CsvImportCommand extends Console
'', '',
sprintf( sprintf(
' [ERROR] File "%s" does not contain valid CSV. ', ' [ERROR] File "%s" does not contain valid CSV. ',
stream_get_meta_data($file)['uri'] ?? 'unknown' $filename ?: 'unknown'
), ),
'' ''
]); ]);
@ -239,7 +240,7 @@ final class CsvImportCommand extends Console
'', '',
sprintf( sprintf(
' [ERROR] File "%s" does not contain mandatory columns. ', ' [ERROR] File "%s" does not contain mandatory columns. ',
stream_get_meta_data($file)['uri'] ?? 'unknown' $filename ?: 'unknown'
), ),
'' ''
]); ]);

5
src/Console/UpdateFormatsCommand.php
View File

@ -60,10 +60,11 @@ final class UpdateFormatsCommand extends Console
$failure = false; $failure = false;
foreach ($formats as $prefix => $format) { foreach ($formats as $prefix => $format) {
if ( if (
/** PHPStan and Psalm don't recognize this as assertion. */
$inDatabase->containsKey($prefix) $inDatabase->containsKey($prefix)
/** @phpstan-ignore-next-line - see line 62 */ /** @phpstan-ignore-next-line - see above */
and $format['namespace'] === $inDatabase[$prefix]->getNamespace() and $format['namespace'] === $inDatabase[$prefix]->getNamespace()
/** @phpstan-ignore-next-line - see line 62 */ /** @phpstan-ignore-next-line - see above */
and $format['schema'] === $inDatabase[$prefix]->getSchema() and $format['schema'] === $inDatabase[$prefix]->getSchema()
) { ) {
continue; continue;