Commit Graph

1954 Commits

Author SHA1 Message Date
Sebastian Meyer b37844559c Improve documentation 2020-04-24 15:06:41 +02:00
Sebastian Meyer 8209a234ef
Merge branch 'master' into allow-absolute-urls 2020-04-24 10:54:00 +02:00
Sebastian Meyer 8a423becd3
Merge pull request #505 from sebastian-meyer/add-cors-header-to-file-proxy
Add CORS header to file proxy
2020-04-24 10:53:23 +02:00
Sebastian Meyer 65434c600a
Fix Codacy issue
Co-Authored-By: Stefan Weil <sw@weilnetz.de>
2020-04-23 17:28:02 +02:00
Sebastian Meyer b3e1df9954 Force absolute URLs for plugin functions as well 2020-04-23 16:04:31 +02:00
Sebastian Meyer e20c3fa684 Restrict to request origin 2020-04-23 14:08:27 +02:00
Sebastian Meyer 51f3bc8bda Limit to GET method 2020-04-23 14:08:07 +02:00
Sebastian Meyer 03581bc3d8 Make usage of absolute links configurable 2020-04-23 12:34:31 +02:00
Sebastian Meyer 4eab8e4a51 Add CORS header 2020-04-23 11:12:55 +02:00
Sebastian Meyer b1131bfd9e
Merge pull request #504 from albig/fix-oai-typo3-87
Fix OAI Plugin for TYPO3 8.7LTS
2020-04-22 11:34:10 +02:00
Alexander Bigga 8afb35c1df fix codacy hint 2020-04-17 17:00:40 +02:00
Alexander Bigga 23a0677045 Fix iteration through results of available OAI sets 2020-04-17 16:48:15 +02:00
Alexander Bigga cbccceaf51 Second argument of expr() must be quoted.
Otherwise the SQL-query is not valid and will fail. See e.g.

https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Database/ExpressionBuilder/Index.html

The Helper::whereExpression() does not work with table tx_dlf_tokens as
the TCA definition exists. With table tx_dlf_structure this query makes
no sense in resume().
2020-04-17 15:04:27 +02:00
Sebastian Meyer 982bacb834
Merge pull request #499 from erik-konrad/master
refactores $GLOBALS['TYPO3_DB'] to QueryBuilder
2020-04-15 14:29:43 +02:00
Sebastian Meyer 08fe8abdd7
Merge branch 'master' into master 2020-04-15 13:13:15 +02:00
erik-konrad c7bf60816b [FIX] refactores oldFormatClasses() Method in class.ext_update.php and removes the escaped backslashes for better DB compatibility 2020-04-09 09:05:29 +02:00
erik-konrad a00079a3fa 9LTS Codacity quality review fix 2020-04-08 16:41:05 +02:00
Sebastian Meyer 26e65ccec8
Merge pull request #501 from albig/fix-syntax-errors
Fix syntax error breaking TYPO3 8.7
2020-04-08 16:28:16 +02:00
Alexander Bigga 64c74f84cd Fix syntax error breaking TYPO3 8.7 2020-04-08 16:20:00 +02:00
erik-konrad e95e9d7d6d [9LTS] Codacy code quality review fixes 2020-04-07 15:58:11 +02:00
erik-konrad 73240230eb [9LTS] code review fixes 2020-04-07 15:45:43 +02:00
erik-konrad 301e1df573 [9LTS] static code analyzer fixes 2020-04-06 15:42:32 +02:00
erik-konrad 04cff89a17 [9LTS] cleanup 2020-04-06 14:29:49 +02:00
erik-konrad 1d28417e4a [9LTS] upgrade method refactoring 2020-04-06 10:48:29 +02:00
erik-konrad 3720dd7894 [9LTS] Extensions module and dlf extension configuration is now working (update script partially upgraded) 2020-04-02 16:25:36 +02:00
erik-konrad a4cab67b78 [TASK] adds vendor, public folders and composer.lock to gitignore 2020-04-02 11:06:23 +02:00
erik-konrad aa59aa17b9 [FIX] updates version number and TYPO3 dependency version for 9LTS support 2020-04-02 10:28:50 +02:00
Sebastian Meyer 66b86b08ff
Merge pull request #496 from albig/fix-search-in-document-page-0
Fix the searchInDocument tool on initial page.
2020-03-16 14:40:32 +01:00
Alexander Bigga 4d0a384909 Fix the searchInDocument tool on initial page.
If calling a document, the parameter tx_dlf[page] may be empty. In this
case usually page 1 is taken. This is the default behaviour of all
plugins. In searchInDocument this part is missing and the search is
disabled on the initial page.
2020-03-16 14:08:39 +01:00
Sebastian Meyer 16543b8380
Merge pull request #495 from albig/feature-jquery3
Upgrade jQuery to 3.4.1
2020-03-13 17:38:57 +01:00
Alexander Bigga 89e852ab68 Replace jQuery libs 2020-03-13 17:27:22 +01:00
Alexander Bigga c871bbb62d fix JavaScript for jQuery > 3.0 2020-03-13 17:27:22 +01:00
Sebastian Meyer 51672d7442
Merge pull request #494 from albig/fix-javascript-regression
Fix JavaScript error introduced with PR #487.
2020-03-13 16:52:19 +01:00
Sebastian Meyer 04483575a5
Remove debugging alert() 2020-03-13 16:36:36 +01:00
Alexander Bigga 7b17dfeae9 Fix JavaScript error introduced with PR 487.
Using the rotate buttons, a JavaScript error is shown in the webconsole:

``Uncaught TypeError: Cannot read property 'rotate' of undefined``

This is due to the change of the condition in OL3.js:

Old:
```
if (this.ov_view != null) {
	this.ov_view.rotate(0);
}
```

New in PR 487:
```
if (this.ov_view !== null) {
	this.ov_view.rotate(0);
}
```

This patch:
```
if (this.ov_view !== null && this.ov_view !== undefined) {
	this.ov_view.rotate(0);
}
```

The problem is, that `this.ov_view` is always `undefined` NOT `null`. So
the change with PR #487 causes the entry into the if condition.

I suspect that the above condition will never work. But I have no idea
how the "magnifier" feature works and didn't get it working.
2020-03-13 15:35:25 +01:00
Sebastian Meyer 7c43a84fd4
Merge pull request #493 from albig/fix-tableofcontents
Fill orderlabel for sub-entries in TableOfContents plugin.
2020-03-13 13:36:25 +01:00
Sebastian Meyer 7c9436dc78
Use `mets_label` as well for consistency 2020-03-13 13:18:50 +01:00
Alexander Bigga 6ad22c0f96 Fill orderlabel for sub-entries in TableOfContents plugin.
With newspaper/ephemera year files the fields title, year, volume,
volume_sorting are not filled. The TableOfContents plugin only shows the
structure type ("Year") on the anchor level.

The label we want to see is the mets_orderlabel in this case. But this
field is not queried in the plugin.

Filling the internal "orderlabel" field in the menuArray fixes this
issue. The "orderlabel" will be filled into the "title" field in
getMenuEntry().

Another issue is fixed in this patch: The ordering of the menu entries.
The sorting does not work if volume is not filled. In this case the
sorting by mets_orderlabel must be used.
2020-03-13 12:31:48 +01:00
Sebastian Meyer 6f63c4438d
Merge pull request #491 from effective-webwork/listview_numeration
Listview numeration
2020-03-13 11:59:56 +01:00
Sebastian Meyer aca18447f1
Merge pull request #489 from sebastian-meyer/fix-codacy-security-issues
Fix codacy security issues
2020-03-13 11:58:50 +01:00
Christopher Timm 405b3d9770 fix listview numeration 2020-03-13 09:14:21 +01:00
Sebastian Meyer 705752474a
Merge pull request #490 from albig/better-markup-pagebrowser
Better markup for listview pagebrowser.
2020-03-10 14:26:50 +01:00
Sebastian Meyer 4bd90033d1
Code Styling 2020-03-10 14:22:55 +01:00
Alexander Bigga 0c2dc7ae6f Better markup for listview pagebrowser.
The current markup of the pagebrowser is as follows:

```
<p class="tx-dlf-pagebrowser">
        &lt; - 1 -
        <a href="/listenansicht?tx_dlf%5Bpointer%5D=1&amp;cHash=eb8b8cfb2f0a3ceff42e4736914db972">2</a>
         -
        <a href="/listenansicht?tx_dlf%5Bpointer%5D=2&amp;cHash=65978b125c84a3989a08d99ca605d932">3</a>
         - ... -
        <a href="/listenansicht?tx_dlf%5Bpointer%5D=307&amp;cHash=fb0b9ec99993a5c2396053d1720bd902">308</a>
         -
        <a href="/listenansicht?tx_dlf%5Bpointer%5D=308&amp;cHash=cb9b71da010da38114ecc62c6c546e94">309</a>
         -
        <a href="/listenansicht?tx_dlf%5Bpointer%5D=309&amp;cHash=cad88079150728e410b34fd4a7558b5e">310</a>
         -
        <a href="/listenansicht?tx_dlf%5Bpointer%5D=1&amp;cHash=eb8b8cfb2f0a3ceff42e4736914db972">&gt;</a>
</p>
```
This is hard to design as the separators, skip, active and previous
"buttons" cannot be styled by CSS.

The current patch changes the markup to the following:

```
<p class="tx-dlf-pagebrowser">
	<span>&lt;</span>
	<span class="separator"> - </span>
	<span class="active">1</span>
	<span class="separator"> - </span>
	<a href="/listenansicht?tx_dlf%5Bpointer%5D=1&amp;cHash=eb8b8cfb2f0a3ceff42e4736914db972">2</a>
	<span class="separator"> - </span>
	<a href="/listenansicht?tx_dlf%5Bpointer%5D=2&amp;cHash=65978b125c84a3989a08d99ca605d932">3</a>
	<span class="separator"> - </span>
	<span class="skip">...</span>
	<span class="separator"> - </span>
	<a href="/listenansicht?tx_dlf%5Bpointer%5D=307&amp;cHash=fb0b9ec99993a5c2396053d1720bd902">308</a>
	<span class="separator"> - </span>
	<a href="/listenansicht?tx_dlf%5Bpointer%5D=308&amp;cHash=cb9b71da010da38114ecc62c6c546e94">309</a>
	<span class="separator"> - </span>
	<a href="/listenansicht?tx_dlf%5Bpointer%5D=309&amp;cHash=cad88079150728e410b34fd4a7558b5e">310</a>
	<span class="separator"> - </span>
	<a href="/listenansicht?tx_dlf%5Bpointer%5D=1&amp;cHash=eb8b8cfb2f0a3ceff42e4736914db972">&gt;</a>
</p>
```
Now, all text may be styled separately. The `<span class="separator">`
could be hidden if the other links and spans are styled as buttons.
2020-03-10 14:06:31 +01:00
Sebastian Meyer e8782da6b9 Fix two more issues 2020-03-04 15:28:53 +01:00
Sebastian Meyer 2bcabcdd23 Use strict comparisons 2020-03-04 15:10:06 +01:00
Sebastian Meyer 28f23028d3 Use method and property shorthands 2020-03-04 14:57:41 +01:00
Sebastian Meyer f14ff1145d Remove debugging console output 2020-03-04 14:46:44 +01:00
Sebastian Meyer 36e1cbd7aa Remove unnecessary semicolon 2020-03-04 14:46:26 +01:00
Sebastian Meyer cfc817de9d Remove Potential Object Injection Sink 2020-03-04 14:36:31 +01:00