If calling a document, the parameter tx_dlf[page] may be empty. In this
case usually page 1 is taken. This is the default behaviour of all
plugins. In searchInDocument this part is missing and the search is
disabled on the initial page.
Using the rotate buttons, a JavaScript error is shown in the webconsole:
``Uncaught TypeError: Cannot read property 'rotate' of undefined``
This is due to the change of the condition in OL3.js:
Old:
```
if (this.ov_view != null) {
this.ov_view.rotate(0);
}
```
New in PR 487:
```
if (this.ov_view !== null) {
this.ov_view.rotate(0);
}
```
This patch:
```
if (this.ov_view !== null && this.ov_view !== undefined) {
this.ov_view.rotate(0);
}
```
The problem is, that `this.ov_view` is always `undefined` NOT `null`. So
the change with PR #487 causes the entry into the if condition.
I suspect that the above condition will never work. But I have no idea
how the "magnifier" feature works and didn't get it working.
With newspaper/ephemera year files the fields title, year, volume,
volume_sorting are not filled. The TableOfContents plugin only shows the
structure type ("Year") on the anchor level.
The label we want to see is the mets_orderlabel in this case. But this
field is not queried in the plugin.
Filling the internal "orderlabel" field in the menuArray fixes this
issue. The "orderlabel" will be filled into the "title" field in
getMenuEntry().
Another issue is fixed in this patch: The ordering of the menu entries.
The sorting does not work if volume is not filled. In this case the
sorting by mets_orderlabel must be used.
The current markup of the pagebrowser is as follows:
```
<p class="tx-dlf-pagebrowser">
< - 1 -
<a href="/listenansicht?tx_dlf%5Bpointer%5D=1&cHash=eb8b8cfb2f0a3ceff42e4736914db972">2</a>
-
<a href="/listenansicht?tx_dlf%5Bpointer%5D=2&cHash=65978b125c84a3989a08d99ca605d932">3</a>
- ... -
<a href="/listenansicht?tx_dlf%5Bpointer%5D=307&cHash=fb0b9ec99993a5c2396053d1720bd902">308</a>
-
<a href="/listenansicht?tx_dlf%5Bpointer%5D=308&cHash=cb9b71da010da38114ecc62c6c546e94">309</a>
-
<a href="/listenansicht?tx_dlf%5Bpointer%5D=309&cHash=cad88079150728e410b34fd4a7558b5e">310</a>
-
<a href="/listenansicht?tx_dlf%5Bpointer%5D=1&cHash=eb8b8cfb2f0a3ceff42e4736914db972">></a>
</p>
```
This is hard to design as the separators, skip, active and previous
"buttons" cannot be styled by CSS.
The current patch changes the markup to the following:
```
<p class="tx-dlf-pagebrowser">
<span><</span>
<span class="separator"> - </span>
<span class="active">1</span>
<span class="separator"> - </span>
<a href="/listenansicht?tx_dlf%5Bpointer%5D=1&cHash=eb8b8cfb2f0a3ceff42e4736914db972">2</a>
<span class="separator"> - </span>
<a href="/listenansicht?tx_dlf%5Bpointer%5D=2&cHash=65978b125c84a3989a08d99ca605d932">3</a>
<span class="separator"> - </span>
<span class="skip">...</span>
<span class="separator"> - </span>
<a href="/listenansicht?tx_dlf%5Bpointer%5D=307&cHash=fb0b9ec99993a5c2396053d1720bd902">308</a>
<span class="separator"> - </span>
<a href="/listenansicht?tx_dlf%5Bpointer%5D=308&cHash=cb9b71da010da38114ecc62c6c546e94">309</a>
<span class="separator"> - </span>
<a href="/listenansicht?tx_dlf%5Bpointer%5D=309&cHash=cad88079150728e410b34fd4a7558b5e">310</a>
<span class="separator"> - </span>
<a href="/listenansicht?tx_dlf%5Bpointer%5D=1&cHash=eb8b8cfb2f0a3ceff42e4736914db972">></a>
</p>
```
Now, all text may be styled separately. The `<span class="separator">`
could be hidden if the other links and spans are styled as buttons.