Commit Graph

2345 Commits

Author SHA1 Message Date
Sebastian Meyer ff15ea8006
Merge pull request #557 from beatrycze-volk/fix-utility
Fix dlfUtils initialization to match Codacy standards
2020-12-08 15:05:04 +01:00
Sebastian Meyer 50a2693418
Merge branch 'master' into fix-utility 2020-12-08 14:52:29 +01:00
Beatrycze Volk 854f739eb3 Fix dlfUtils initialization to match Codacy standards 2020-12-08 14:46:52 +01:00
Sebastian Meyer b703828702
Merge pull request #556 from beatrycze-volk/fulltextutility
Add FullTextUtility for methods common for full text plugins
2020-12-08 14:45:48 +01:00
Beatrycze Volk 5e0c8ee824 Fix Codacy issues for FullTextUtility usage 2020-12-08 14:38:29 +01:00
Beatrycze Volk 72bde676c3 Add FullTextUtility for methods common for full text plugins 2020-12-08 13:18:29 +01:00
Sebastian Meyer 6dbfb34d71
Merge pull request #548 from beatrycze-volk/higlight-fulltext
Fix scrolling to the highlighted full text element
2020-12-08 13:12:43 +01:00
Sebastian Meyer 08704f87ff
Merge branch 'master' into higlight-fulltext 2020-12-08 12:35:42 +01:00
Beatrycze Volk 5f99396f59 Fix scrolling to the highlighted full text element 2020-12-08 11:58:49 +01:00
Sebastian Meyer 9924217c51
Merge pull request #552 from beatrycze-volk/fix-fullext-controls-condition
Fix condition check for adding full text control
2020-12-08 11:37:36 +01:00
Sebastian Meyer 7c9ac7ddfb
Update code_analyzer.yml 2020-12-08 11:32:33 +01:00
Sebastian Meyer 5eca096f14
Remove default comment 2020-12-07 12:03:35 +01:00
Sebastian Meyer 5f23ffca7d
Add Codacy Security Scan to Actions 2020-12-07 11:56:12 +01:00
Sebastian Meyer abb26c4733 Make input fields read-only 2020-12-06 17:52:57 +01:00
Sebastian Meyer 8b6e7df541 Make changing index_name optional 2020-12-06 17:20:46 +01:00
Sebastian Meyer 51c63f2800 Make index_name editable 2020-12-06 17:18:30 +01:00
Beatrycze Volk f8e3d8b241 Fix condition check for adding full text control
this.fulltexts[0] is actually an empty array, so it passed check for undefined and url was not empty string as it doesn't exists
2020-12-03 19:01:27 +01:00
Beatrycze Volk 446a4345d4 Update Solarium to 5.1.6 2020-12-01 16:27:57 +01:00
Alexander Bigga 0092fb9447
Merge pull request #4 from kitodo/scrutinizer-patch-1
Scrutinizer Auto-Fixes
2020-11-20 20:26:43 +01:00
Scrutinizer Auto-Fixer fcc17ec87f Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-11-20 19:25:35 +00:00
Alexander Bigga d312b1d8ee Fix search in documents for hierarchical documents like newspaper.
== Current Situation

The search plugin has the option to restrict the search in current
document and/or in current collection. This can be used to place the
plugin on a separate page to search only in one collection. Or you place
the plugin on the workview page and trigger a search in document.

Of course, the SearchInDocument plugin is better suited for the workview as the results are reported by via AJAX and the visitor will stay on the current page.

On the opposite, using the search plugin makes it possible to search
in all issues of a newspaper year or even a full newspaper title. At
least, this should be possible. The current implementation does not work
as expected.

=== Example

==== Search plugin on workview (issue)

For example, you can place the plugin on level of a newspaper issue. If
you launch a search, the current implementation will search not only in
current issue but in all issues of the current year. This is a
frequently demanded feature but works only by hasard.

newspaper title (anchor)
   |
   |-> year
        |
        |-> Issue

The current search plugin does two mistakes:

1. Instead of the current document uid, the parent uid is set.
2. The search is done in given uid and all children.

==== Search plugin on workview (year/anchor)

If you place the search plugin on the workview with calendar view, the
search fails.

Same procedure as above. The search will be done in the anchor and it's
children (years). All these files have no fulltexts. So the result is
always empty.

== Proposed Implementation

The proposed implementation does change the searchIn document limitation
of the search plugin to search in current document _and_ all it's children.

This is done on using Solr join feature. To make this possible, the
partof field must use the docValues feature as "uid" does it already.
2020-11-20 16:16:48 +01:00
Sebastian Meyer a12df1d4e1
Merge pull request #541 from sebastian-meyer/update-sonarcloud-config
Update SonarCloud configuration
2020-08-18 16:02:36 +02:00
Sebastian Meyer edeaeb5c63 Remove checks for pull requests 2020-08-18 13:27:05 +02:00
Sebastian Meyer 3db475cb9f Set encoding to UTF-8 2020-08-18 13:26:40 +02:00
Sebastian Meyer 7db7fa33e9
Merge pull request #539 from albig/fix-538
Replace deprecated usage of shortcut methold .load().
2020-08-10 18:11:57 +02:00
Alexander Bigga d8810f0638 Replace deprecated usage of shortcut methold .load().
Background: https://api.jquery.com/load-event/

<pre>
Note: This API has been removed in jQuery 3.0; please
use .on( "load", handler ) instead of .load( handler )
and .trigger( "load" ) instead of .load().
</pre>
2020-08-10 16:15:42 +02:00
Sebastian Meyer f9b811f86d
Merge pull request #535 from kitodo/sonarcloud
Add Action for Static Code Analyzing
2020-07-29 13:59:44 +02:00
Sebastian Meyer 859bb60159
Merge branch 'master' into sonarcloud 2020-07-29 13:56:09 +02:00
Sebastian Meyer a91a997265
Merge pull request #536 from sebastian-meyer/fix-xss-issue
Fix XSS issue
2020-07-29 13:46:06 +02:00
Sebastian Meyer 4d24820792
Update PHP version constraints 2020-07-29 12:53:10 +02:00
Sebastian Meyer bbdd8f77f7 Update version information 2020-07-28 14:28:53 +02:00
Sebastian Meyer bbb2e41f86 Mitigate potential backend attack 2020-07-27 18:28:24 +02:00
Sebastian Meyer 6a67256388 Fix XSS issue 2020-07-27 14:34:01 +02:00
Sebastian Meyer d610bf613a
Clarify documentation 2020-07-24 13:24:01 +02:00
Sebastian Meyer 1dd1cfde18 Add Sonarcloud quality badges 2020-07-23 16:12:01 +02:00
Sebastian Meyer f7b427da5c Update Sonarcloud configuration 2020-07-23 14:11:38 +02:00
Sebastian Meyer e155381e52 Update Sonarcloud project key 2020-07-23 13:44:31 +02:00
Sebastian Meyer 804aaa947a Add Sonarcloud configuration 2020-07-23 13:32:41 +02:00
Sebastian Meyer 3301041a4b
Add Action for Static Code Analyzing 2020-07-23 13:23:56 +02:00
Sebastian Meyer 769f341962
Merge pull request #534 from sebastian-meyer/fix-533
Update jQuery
2020-07-22 20:24:20 +02:00
Sebastian Meyer f842e69cab
Update .gitignore 2020-07-22 13:34:50 +02:00
Sebastian Meyer 1b6307ba0d Update .gitignore 2020-07-22 12:24:03 +02:00
Sebastian Meyer 83a80891c1 [SECURITY] Update jQuery 2020-07-22 12:23:59 +02:00
Sebastian Meyer 9a8aeae3a2
Merge pull request #532 from kitodo/whitesource/configure
Configure WhiteSource Bolt for GitHub
2020-07-22 12:04:21 +02:00
Sebastian Meyer 3caac51918
Update .whitesource 2020-07-22 11:56:50 +02:00
whitesource-bolt-for-github[bot] 1aabf23969
Add .whitesource configuration file 2020-07-22 08:44:04 +00:00
Sebastian Meyer ead0c994fb
Merge pull request #525 from kitodo/add-security-policy
Add security policy and update issue templates
2020-07-16 08:00:03 +02:00
Sebastian Meyer 29777a5d8f
Merge branch 'master' into add-security-policy 2020-07-16 05:34:09 +02:00
Sebastian Meyer b7cf42f6e0
Merge pull request #530 from sebastian-meyer/release-3.1.1
Prepare Release of v3.1.1
2020-07-15 17:13:51 +02:00
Sebastian Meyer 344a992ec5 Raise version number for release 2020-07-15 16:11:51 +02:00