Commit Graph

266 Commits

Author SHA1 Message Date
Alexander Bigga 466dcafc32
Merge branch 'master' into allow-multiple-filegrps 2021-03-24 11:19:16 +01:00
Sebastian Meyer ecd8ec8422
Merge branch 'master' into allow-multiple-filegrps 2021-03-23 13:51:13 +01:00
Alexander Bigga 5c50fd8d8c
Update Classes/Plugin/Collection.php
Co-authored-by: Sebastian Meyer <sebastian.meyer@slub-dresden.de>
2021-03-23 13:26:11 +01:00
Sebastian Meyer 440d9bcf69
Merge branch 'master' into fix-559 2021-03-22 23:33:58 +01:00
Alexander Bigga 9cac0e0639 Make the collection listview more robust agains missing volume_sorting.
Currently the volume_sorting field is used as array key. But in some
circumstances this field is empty or the same value is used. Both will
lead to an incomplete list of elements.

This commit appends the record uid to make sure, the array key is
unique.
2021-03-22 22:55:08 +01:00
Alexander Bigga 698773c5f4
Update Classes/Plugin/Tools/FulltextTool.php
Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
2021-03-22 16:44:50 +01:00
Sebastian Meyer d4771b7308
Merge branch 'master' into search-highlight-word 2021-03-11 10:31:53 +01:00
Sebastian Meyer a30c459126
Use correct bibliographic terms 2021-03-10 10:33:30 +01:00
Scrutinizer Auto-Fixer 79d9a5aab3 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2021-03-08 20:29:05 +00:00
Alexander Bigga b55efa21aa Change first filterQuery to sub-query as it is not accepted/executed otherwise. 2021-03-08 21:05:49 +01:00
Alexander Bigga 13ea40ae37 Simplify code (Scrutinizer hint) 2021-03-07 11:47:33 +01:00
Alexander Bigga 914c3b1f06 Reenable search in year types with descendants and single documents. 2021-03-07 08:54:26 +01:00
Alexander Bigga b69d040e81
Merge branch 'master' into search-plugin-enhance 2021-03-03 17:18:08 +01:00
Sebastian Meyer 52d6d2cef1 Fix small typos 2021-02-23 09:26:32 +01:00
Sebastian Meyer 7e23280a1d Make variable names more consistent 2021-02-23 09:26:17 +01:00
Sebastian Meyer 40c738f147 Fix syntax error 2021-02-17 21:48:20 +01:00
Sebastian Meyer 390763a10b Fix Codacy issue 2021-02-17 20:34:08 +01:00
Sebastian Meyer 63beb3a21b Allow multiple file groups 2021-02-17 20:08:21 +01:00
Sebastian Meyer 094d9ed1f1 Remove MIN from default fileGrps 2021-02-17 09:04:40 +01:00
Beatrycze Volk ecb817909e Add configuration for fields which need to be highlighted in the image 2021-02-16 12:59:14 +01:00
Alexander Bigga a9497e0da2
Merge branch 'master' into search-plugin-enhance 2021-02-05 10:02:32 +01:00
Sebastian Meyer 2799b9bea2
Merge branch 'master' into use-strong-cryptography 2021-01-26 23:32:45 +01:00
Beatrycze Volk b02f691ed7 Import MathUtility for increase of code readability 2021-01-21 11:35:31 +01:00
Beatrycze Volk 593d8e20e2 Make scroll element for full text scrolling configurable 2021-01-21 11:35:31 +01:00
Sebastian Meyer 6c8b905981 Use AES-256-GCM and SHA256 2021-01-19 14:08:09 +01:00
Scrutinizer Auto-Fixer 3c7332f422 Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-12-29 15:42:47 +00:00
Alexander Bigga 319db25411 Sanitize new TypoScript setting activateFullTextInitially 2020-12-29 14:54:16 +01:00
Beatrycze Volk d0b2a572d9 Change launch state to numerical value and add activation on link click 2020-12-29 12:01:14 +01:00
Sebastian Meyer 11819891d2
Merge branch 'master' into fix-solarium-upgrade 2020-12-28 11:03:59 +01:00
Sebastian Meyer 558839eabb
Update Classes/Plugin/Eid/SearchSuggest.php
Co-authored-by: Alexander Bigga <alexander.bigga@slub-dresden.de>
2020-12-28 10:59:15 +01:00
Sebastian Meyer 301bc6d65b Replace suggester with select request handler 2020-12-27 12:45:44 +01:00
Sebastian Meyer 4c88e37a71 Fix SearchSuggest 2020-12-23 09:39:51 +01:00
Sebastian Meyer d5c882a0ff Fix SearchInDocument 2020-12-23 08:55:37 +01:00
Sebastian Meyer 5c9d79ae2d Make Solr instantiation more robust 2020-12-21 09:13:19 +01:00
Sebastian Meyer b9ca493018 Update Solarium to 5.2.x 2020-12-20 16:06:00 +01:00
Beatrycze Volk 77a02a0f0a Remove configuration variable dump 2020-12-16 14:34:34 +01:00
Beatrycze Volk 348f18964f Change duplicated plugin to switch which changes full text behavior 2020-12-14 17:52:50 +01:00
Beatrycze Volk 12355f4cd9 Add full text download tool and duplicate full text display for always
active display
2020-12-14 15:26:56 +01:00
Beatrycze Volk 72bde676c3 Add FullTextUtility for methods common for full text plugins 2020-12-08 13:18:29 +01:00
Scrutinizer Auto-Fixer fcc17ec87f Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-11-20 19:25:35 +00:00
Alexander Bigga d312b1d8ee Fix search in documents for hierarchical documents like newspaper.
== Current Situation

The search plugin has the option to restrict the search in current
document and/or in current collection. This can be used to place the
plugin on a separate page to search only in one collection. Or you place
the plugin on the workview page and trigger a search in document.

Of course, the SearchInDocument plugin is better suited for the workview as the results are reported by via AJAX and the visitor will stay on the current page.

On the opposite, using the search plugin makes it possible to search
in all issues of a newspaper year or even a full newspaper title. At
least, this should be possible. The current implementation does not work
as expected.

=== Example

==== Search plugin on workview (issue)

For example, you can place the plugin on level of a newspaper issue. If
you launch a search, the current implementation will search not only in
current issue but in all issues of the current year. This is a
frequently demanded feature but works only by hasard.

newspaper title (anchor)
   |
   |-> year
        |
        |-> Issue

The current search plugin does two mistakes:

1. Instead of the current document uid, the parent uid is set.
2. The search is done in given uid and all children.

==== Search plugin on workview (year/anchor)

If you place the search plugin on the workview with calendar view, the
search fails.

Same procedure as above. The search will be done in the anchor and it's
children (years). All these files have no fulltexts. So the result is
always empty.

== Proposed Implementation

The proposed implementation does change the searchIn document limitation
of the search plugin to search in current document _and_ all it's children.

This is done on using Solr join feature. To make this possible, the
partof field must use the docValues feature as "uid" does it already.
2020-11-20 16:16:48 +01:00
Sebastian Meyer bbb2e41f86 Mitigate potential backend attack 2020-07-27 18:28:24 +02:00
Sebastian Meyer 6a67256388 Fix XSS issue 2020-07-27 14:34:01 +02:00
Sebastian Meyer bc70ef30b8
Fix typo 2020-07-15 15:27:13 +02:00
Sebastian Meyer 90ba416f10 Sanitize URL parameters before adding them to form fields 2020-07-15 15:07:52 +02:00
Sebastian Meyer 95130f5ea6
Merge branch 'master' into fix-db-queries-for-9.x 2020-05-25 23:03:49 +02:00
Sebastian Meyer a91665ba75
Merge branch 'master' into fix-520 2020-05-25 22:59:28 +02:00
Alexander Bigga 8c5c32b640 Always use the index_name of the default language in collection plugin 2020-05-25 15:00:12 +02:00
Sebastian Meyer 99b50b491b
Merge branch 'master' into fix-db-queries-for-9.x 2020-05-25 11:46:44 +02:00
Sebastian Meyer a12f9d472b Fix Codacy issue 2020-05-22 20:09:04 +02:00